----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124695/#review83690 -----------------------------------------------------------
Ship it! Two notes: a) no idea how epoxy works, but it doesn't link any GL library itself here (it's an epoxy build time dependency, though) b) fglrx doesn't support EGL - though rather irrelevant since EGL from MESA will just be installed (as qt5-base dependency already) and not used, afaics there actually is a way to build a GLX system only. - Thomas Lübking On Aug. 11, 2015, 8:29 vorm., Martin Gräßlin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124695/ > ----------------------------------------------------------- > > (Updated Aug. 11, 2015, 8:29 vorm.) > > > Review request for kwin and Plasma. > > > Repository: kwin > > > Description > ------- > > It doesn't make much sense any more as we get EGL linked and included > through epoxy anyway. Even more on Wayland it's just plain stupid to > have EGL disabled. So removing the option just simplifies our code base > without any disadvantages. > > > Diffs > ----- > > libkwineffects/kwinglutils.cpp 66634d6795d43020e9f323af9c24d8bfae9bf4aa > libkwineffects/kwinconfig.h.cmake 3e34723aea5baf519c16f53afef3b21ab43efe7c > dbusinterface.cpp 01079a1b2a97c83e4624deafb288349ea3952c7f > backends/x11/x11windowed_backend.cpp > 3ba9e5cd3932574daff2062a289dfd00745fa776 > backends/wayland/CMakeLists.txt a1670a34b1f6519f6fb37bc041516bf3aec508e1 > CMakeLists.txt 4d2aeed4f5ee9d0765e1b902ac51859e0ae1150b > libkwineffects/kwinglutils_funcs.h eea28c5ae4225939a3d7fe72167fea4bfe028298 > libkwineffects/kwinglutils_funcs.cpp > 4e763b7bb1c4e156b52639dd357c92c5f28e9937 > options.cpp 39efd9de53024fb7f11d042b7877a4583350b651 > scene_opengl.cpp 85c0b104785ee2f06b1698d8e8020e0615fdab88 > > Diff: https://git.reviewboard.kde.org/r/124695/diff/ > > > Testing > ------- > > > Thanks, > > Martin Gräßlin > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel