----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124799/#review83980 -----------------------------------------------------------
I don't think copying all of this is a good idea. Can this be shared somehow? - Kai Uwe Broulik On Aug. 18, 2015, 12:55 vorm., Jeremy Whiting wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124799/ > ----------------------------------------------------------- > > (Updated Aug. 18, 2015, 12:55 vorm.) > > > Review request for Plasma, andreas kainz and Sebastian Kügler. > > > Repository: breeze > > > Description > ------- > > 2 problems: > 1. Switching themes causes konversation, krunner, and other applications to > crash when applying the theme somehow. > 2. The screenshots and assets are all copied directly from plasma-workspace, > so the tooltip and such are wrong. > > > Diffs > ----- > > CMakeLists.txt aaae1ab9e242d7d4f9e1fb91990eef139668de74 > lookandfeel.dark/Messages.sh PRE-CREATION > lookandfeel.dark/contents/components/BreezeBlock.qml PRE-CREATION > lookandfeel.dark/contents/components/BreezeHeading.qml PRE-CREATION > lookandfeel.dark/contents/components/BreezeLabel.qml PRE-CREATION > lookandfeel.dark/contents/components/InfoPane.qml PRE-CREATION > lookandfeel.dark/contents/components/KeyboardLayoutButton.qml PRE-CREATION > lookandfeel.dark/contents/components/LogoutOptions.qml PRE-CREATION > lookandfeel.dark/contents/components/LogoutScreen.qml PRE-CREATION > lookandfeel.dark/contents/components/UserDelegate.qml PRE-CREATION > lookandfeel.dark/contents/components/UserList.qml PRE-CREATION > lookandfeel.dark/contents/components/UserSelect.qml PRE-CREATION > lookandfeel.dark/contents/components/artwork/README.txt PRE-CREATION > lookandfeel.dark/contents/components/artwork/background.png PRE-CREATION > lookandfeel.dark/contents/components/artwork/logout_primary.svgz > PRE-CREATION > lookandfeel.dark/contents/components/artwork/restart_primary.svgz > PRE-CREATION > lookandfeel.dark/contents/components/artwork/shutdown_primary.svgz > PRE-CREATION > lookandfeel.dark/contents/defaults PRE-CREATION > lookandfeel.dark/contents/desktopswitcher/DesktopSwitcher.qml PRE-CREATION > lookandfeel.dark/contents/lockscreen/LockScreen.qml PRE-CREATION > lookandfeel.dark/contents/loginmanager/Main.qml PRE-CREATION > lookandfeel.dark/contents/loginmanager/README.txt PRE-CREATION > lookandfeel.dark/contents/loginmanager/breeze.jpg PRE-CREATION > lookandfeel.dark/contents/loginmanager/dummydata/screenModel.qml > PRE-CREATION > lookandfeel.dark/contents/loginmanager/dummydata/sddm.qml PRE-CREATION > lookandfeel.dark/contents/loginmanager/dummydata/sessionModel.qml > PRE-CREATION > lookandfeel.dark/contents/loginmanager/dummydata/userModel.qml PRE-CREATION > lookandfeel.dark/contents/loginmanager/metadata.desktop PRE-CREATION > lookandfeel.dark/contents/loginmanager/theme.conf PRE-CREATION > lookandfeel.dark/contents/logout/Logout.qml PRE-CREATION > lookandfeel.dark/contents/logout/dummydata/screenGeometry.qml PRE-CREATION > lookandfeel.dark/contents/osd/Osd.qml PRE-CREATION > lookandfeel.dark/contents/osd/OsdItem.qml PRE-CREATION > lookandfeel.dark/contents/previews/desktopswitcher.png PRE-CREATION > lookandfeel.dark/contents/previews/lockscreen.png PRE-CREATION > lookandfeel.dark/contents/previews/loginmanager.png PRE-CREATION > lookandfeel.dark/contents/previews/preview.png PRE-CREATION > lookandfeel.dark/contents/previews/runcommand.png PRE-CREATION > lookandfeel.dark/contents/previews/splash.png PRE-CREATION > lookandfeel.dark/contents/previews/userswitcher.png PRE-CREATION > lookandfeel.dark/contents/previews/windowdecoration.png PRE-CREATION > lookandfeel.dark/contents/previews/windowswitcher.png PRE-CREATION > lookandfeel.dark/contents/runcommand/RunCommand.qml PRE-CREATION > lookandfeel.dark/contents/splash/CMakeLists.txt PRE-CREATION > lookandfeel.dark/contents/splash/Splash.qml PRE-CREATION > lookandfeel.dark/contents/splash/images/kde.svgz PRE-CREATION > lookandfeel.dark/contents/userswitcher/UserSwitcher.qml PRE-CREATION > lookandfeel.dark/contents/windowdecoration/WindowDecoration.qml > PRE-CREATION > lookandfeel.dark/contents/windowswitcher/WindowSwitcher.qml PRE-CREATION > lookandfeel.dark/metadata.desktop PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/124799/diff/ > > > Testing > ------- > > Switching between breeze, breeze dark, and oxygen seem to work, though some > artifacts are left in some applications and some others crash for some > reason. The backtrace looks like this: > > Application: Konversation (konversation), signal: Segmentation fault > Using host libthread_db library "/usr/lib/libthread_db.so.1". > [Current thread is 1 (Thread 0x7f76e0f69840 (LWP 3767))] > > Thread 2 (Thread 0x7f76c894d700 (LWP 3769)): > #0 0x00007f76d8dc318d in poll () from /usr/lib/libc.so.6 > #1 0x00007f76d485bc7c in ?? () from /usr/lib/libglib-2.0.so.0 > #2 0x00007f76d485bd8c in g_main_context_iteration () from > /usr/lib/libglib-2.0.so.0 > #3 0x00007f76d9c0f25b in > QEventDispatcherGlib::processEvents(QFlags<QEventLoop::ProcessEventsFlag>) () > from /usr/lib/libQt5Core.so.5 > #4 0x00007f76d9bb626a in > QEventLoop::exec(QFlags<QEventLoop::ProcessEventsFlag>) () from > /usr/lib/libQt5Core.so.5 > #5 0x00007f76d99d2af4 in QThread::exec() () from /usr/lib/libQt5Core.so.5 > #6 0x00007f76d99d7a9e in ?? () from /usr/lib/libQt5Core.so.5 > #7 0x00007f76d63204a4 in start_thread () from /usr/lib/libpthread.so.0 > #8 0x00007f76d8dcc12d in clone () from /usr/lib/libc.so.6 > > Thread 1 (Thread 0x7f76e0f69840 (LWP 3767)): > [KCrash Handler] > #6 0x00007f76dade2f72 in QApplication::setStyle(QStyle*) () from > /usr/lib/libQt5Widgets.so.5 > #7 0x00007f76dade3f06 in QApplication::setStyle(QString const&) () from > /usr/lib/libQt5Widgets.so.5 > #8 0x00007f76c9c34733 in KHintsSettings::slotNotifyChange (this=0x1eef110, > type=2, arg=0) at > /home/jeremy/devel/kde/src/frameworks/frameworkintegration/src/platformtheme/khintssettings.cpp:274 > #9 0x00007f76c9c47007 in KHintsSettings::qt_static_metacall (_o=0x1eef110, > _c=QMetaObject::InvokeMetaMethod, _id=3, _a=0x7fff0c69d1d0) at > /home/jeremy/devel/kde/build/frameworks/frameworkintegration/src/platformtheme/moc_khintssettings.cpp:85 > #10 0x00007f76c9c47100 in KHintsSettings::qt_metacall (this=0x1eef110, > _c=QMetaObject::InvokeMetaMethod, _id=3, _a=0x7fff0c69d1d0) at > /home/jeremy/devel/kde/build/frameworks/frameworkintegration/src/platformtheme/moc_khintssettings.cpp:117 > #11 0x00007f76da29c293 in ?? () from /usr/lib/libQt5DBus.so.5 > #12 0x00007f76d9be7eb1 in QObject::event(QEvent*) () from > /usr/lib/libQt5Core.so.5 > #13 0x00007f76dade100c in QApplicationPrivate::notify_helper(QObject*, > QEvent*) () from /usr/lib/libQt5Widgets.so.5 > #14 0x00007f76dade64e6 in QApplication::notify(QObject*, QEvent*) () from > /usr/lib/libQt5Widgets.so.5 > #15 0x00007f76d9bb889b in QCoreApplication::notifyInternal(QObject*, QEvent*) > () from /usr/lib/libQt5Core.so.5 > #16 0x00007f76d9bbac96 in QCoreApplicationPrivate::sendPostedEvents(QObject*, > int, QThreadData*) () from /usr/lib/libQt5Core.so.5 > #17 0x00007f76d9c0ee33 in ?? () from /usr/lib/libQt5Core.so.5 > #18 0x00007f76d485b9fd in g_main_context_dispatch () from > /usr/lib/libglib-2.0.so.0 > #19 0x00007f76d485bce0 in ?? () from /usr/lib/libglib-2.0.so.0 > #20 0x00007f76d485bd8c in g_main_context_iteration () from > /usr/lib/libglib-2.0.so.0 > #21 0x00007f76d9c0f23f in > QEventDispatcherGlib::processEvents(QFlags<QEventLoop::ProcessEventsFlag>) () > from /usr/lib/libQt5Core.so.5 > #22 0x00007f76d9bb626a in > QEventLoop::exec(QFlags<QEventLoop::ProcessEventsFlag>) () from > /usr/lib/libQt5Core.so.5 > #23 0x00007f76d9bbe20c in QCoreApplication::exec() () from > /usr/lib/libQt5Core.so.5 > #24 0x00000000004cbb35 in main (argc=1, argv=<optimized out>) at > /home/jeremy/devel/kde/src/extragear/network/konversation/src/main.cpp:160 > > > Thanks, > > Jeremy Whiting > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel