> On Aug. 28, 2015, 9:52 a.m., David Edmundson wrote:
> > Thanks for looking into this.
> > 
> > This looks like it is going to break the UI being tab-navigatable, which we 
> > can't have.
> > 
> > Any idea what item is taking focus when this occurs?
> 
> Martin Gräßlin wrote:
>     > Any idea what item is taking focus when this occurs?
>     
>     Given the description I assume that it's a low level X call to force 
> focus on KAlarm window which causes the greeter to lose focus and our locker 
> not properly restoring.
> 
> Kåre Särs wrote:
>     I just tried on a multi-monitor setup and it seemed to function as 
> expected with that, but the tab-navigation is broken, so this is not the 
> proper solution...
> 
> Martin Gräßlin wrote:
>     do you know where the code for kalarm lives? I need to look at what it 
> actually does.
> 
> David Edmundson wrote:
>     kdepim repo
> 
> Martin Gräßlin wrote:
>     I don't see anything more evil than activateWindow()
> 
> Martin Gräßlin wrote:
>     quite reproducable without needing kalarm:
>     1. sleep 5 && krunner
>     2. lock screen
>     3. wait and watch the input field
> 
> Martin Gräßlin wrote:
>     I think I have an idea for a solution: filter out XCB_FOCUS_OUT events.

and here we go: https://git.reviewboard.kde.org/r/124966/


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124956/#review84515
-----------------------------------------------------------


On Aug. 27, 2015, 8:53 p.m., Kåre Särs wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124956/
> -----------------------------------------------------------
> 
> (Updated Aug. 27, 2015, 8:53 p.m.)
> 
> 
> Review request for Plasma and David Edmundson.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> If KAlarm pops up a window when the screen is locked it steals the focus from 
> the password field. With this patch the focus is stolen back immediately.
> 
> 
> Diffs
> -----
> 
>   lookandfeel/contents/lockscreen/LockScreen.qml 4ce9a00 
> 
> Diff: https://git.reviewboard.kde.org/r/124956/diff/
> 
> 
> Testing
> -------
> 
> Set KAlarm to open a new "display alarm" after a minute, lock the screen and 
> see the focus go away when the minute changes.
> 
> Apply the patch, set KAlarm to open another display alarm, lock the screen 
> and wait for the minute to change and notice that the focus has not gone 
> anywhere this time.
> 
> 
> Thanks,
> 
> Kåre Särs
> 
>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Reply via email to