----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125030/#review84774 -----------------------------------------------------------
I'll re-raise general concerns about the contrast effect. Why does it exist in the first place? https://bugs.kde.org/show_bug.cgi?id=337355#c12 - Thomas Lübking On Sept. 2, 2015, 4:23 nachm., Marco Martin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125030/ > ----------------------------------------------------------- > > (Updated Sept. 2, 2015, 4:23 nachm.) > > > Review request for kwin and Plasma. > > > Repository: kwayland > > > Description > ------- > > new wayland protocol used to define regions behind a window > in which the kwin background contrast effect should be applied > > > Diffs > ----- > > autotests/client/CMakeLists.txt acc1cc0 > autotests/client/test_wayland_contrast.cpp PRE-CREATION > src/client/CMakeLists.txt e269997 > src/client/contrast.h PRE-CREATION > src/client/contrast.cpp PRE-CREATION > src/client/protocols/contrast.xml PRE-CREATION > src/client/registry.h 2a31ab4 > src/client/registry.cpp e890c69 > src/server/CMakeLists.txt 9d99325 > src/server/display.h cd43b03 > src/server/display.cpp 75adc14 > src/server/surface_interface.h f8f9be7 > src/server/surface_interface.cpp 0f62d13 > src/server/surface_interface_p.h 2b55f81 > > Diff: https://git.reviewboard.kde.org/r/125030/diff/ > > > Testing > ------- > > fail in autotests: fun converting between double and "fixed" > Actual (serverSurface->contrast()->contrast()): 0.199219 > Expected (0.2) : 0.2 > > > Thanks, > > Marco Martin > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
