> On Sept. 6, 2015, 2:22 a.m., Thomas Pfeiffer wrote: > > Have you thought of the corner cases? > > These come to my mind: > > - Is it possible to add the same folder to both lists? If so: Which one > > wins? > > - It ist possible to add a folder to index within an excluded folder? If > > so: what happens? > > - Is it possible to exclude a folder which is _not_ within an included > > folder (not strictly a problem as it would simply have no effect, but > > strange nonetheless)? > > Ovidiu-Florin BOGDAN wrote: > You are right. I didn't consider those scenarios. > 1. In this case, the decision is up to baloo, but I'll look into > implementing a failsafe to not alow this. > 2. Again, the question is: if baloo accepts this. I don't see why this > shouldn't be allowed. Currently there is nothing in the KCM stoping this to > happen. > 3. Yes, it is. Maybe someone is really paranoia, and they whant to make > sure that that directory does not get indexexd under any circumstances. > > Another scenario would be if a directory is added to be excluded, but > there are currently child directories of that directory that are included. In > this case, I'd show a warning, but let the user do it. > > > P.S. Please take a look over the Review Requests that this one depends > on. I can't submit the other patches untill these are in the repo. They > depend on these. > > Vishesh Handa wrote: > What review requests?
Found them. Sorry for the noise. Could you please add the Baloo group / or me next time. Plasma has too much traffic for me to monitor. - Vishesh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125058/#review84886 ----------------------------------------------------------- On Sept. 5, 2015, 8:11 p.m., Ovidiu-Florin BOGDAN wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125058/ > ----------------------------------------------------------- > > (Updated Sept. 5, 2015, 8:11 p.m.) > > > Review request for Baloo, Plasma, KDE Usability, Pinak Ahuja, and Vishesh > Handa. > > > Repository: plasma-desktop > > > Description > ------- > > Added the functionality to add directories to be indexed. > Did some cleaning up. > > Screenshot of the new look: http://i.imgur.com/RBWxutv.png > > > Diffs > ----- > > kcms/baloo/CMakeLists.txt 7415289 > kcms/baloo/configwidget.ui 512e4a5 > kcms/baloo/folderselectionwidget.h 226ab45 > kcms/baloo/folderselectionwidget.cpp b44d111 > kcms/baloo/kcm.h 6ff5813 > kcms/baloo/kcm.cpp 27d93e2 > > Diff: https://git.reviewboard.kde.org/r/125058/diff/ > > > Testing > ------- > > Tested add, remove include and exclude directories. > > > Thanks, > > Ovidiu-Florin BOGDAN > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
