> On Sept. 6, 2015, 5:26 p.m., Vishesh Handa wrote: > > kcms/baloo/folderselectionwidget.cpp, line 129 > > <https://git.reviewboard.kde.org/r/125062/diff/1/?file=400390#file400390line129> > > > > Does this actually compile? Because 'folderDisplayName' does not exist > > for me.
Oh, my, this diff is incomplete. I'll update it. - Ovidiu-Florin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125062/#review84898 ----------------------------------------------------------- On Sept. 5, 2015, 11:05 p.m., Ovidiu-Florin BOGDAN wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125062/ > ----------------------------------------------------------- > > (Updated Sept. 5, 2015, 11:05 p.m.) > > > Review request for Plasma. > > > Repository: plasma-desktop > > > Description > ------- > > This way the name of the variable is more descriptive with it's purpose. > > > Diffs > ----- > > kcms/baloo/folderselectionwidget.cpp b44d111 > > Diff: https://git.reviewboard.kde.org/r/125062/diff/ > > > Testing > ------- > > > Thanks, > > Ovidiu-Florin BOGDAN > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
