----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125117/#review85057 -----------------------------------------------------------
kcms/baloo/kcm.cpp (line 165) <https://git.reviewboard.kde.org/r/125117/#comment58818> the { goes to new line kcms/baloo/kcm.cpp (line 167) <https://git.reviewboard.kde.org/r/125117/#comment58815> const QStorageInfo &si kcms/baloo/kcm.cpp (lines 168 - 169) <https://git.reviewboard.kde.org/r/125117/#comment58816> You can do it directly -- mountPoints << si.displayName() kcms/baloo/kcm.cpp (lines 174 - 177) <https://git.reviewboard.kde.org/r/125117/#comment58817> This can also stay like it was, just do return excluded.toSet() == mountPoints.toSet(); ...it will return the result of that comparison. Or even return m_excludeFolders_FSW->excludeFolders().toSet() == mountPoints.toSet(); to simplify it completely. - Martin Klapetek On Sept. 9, 2015, 8:04 p.m., Ovidiu-Florin BOGDAN wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125117/ > ----------------------------------------------------------- > > (Updated Sept. 9, 2015, 8:04 p.m.) > > > Review request for Baloo, Plasma and Vishesh Handa. > > > Repository: plasma-desktop > > > Description > ------- > > And simplified the way it searches for the mount points. > > > Diffs > ----- > > kcms/baloo/folderselectionwidget.h 6430b60 > kcms/baloo/folderselectionwidget.cpp 3ad1764 > kcms/baloo/kcm.h 6878e89 > kcms/baloo/kcm.cpp d85f615 > > Diff: https://git.reviewboard.kde.org/r/125117/diff/ > > > Testing > ------- > > Compiled and used. > > > Thanks, > > Ovidiu-Florin BOGDAN > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
