----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125063/#review85064 -----------------------------------------------------------
Ship it! gui/SensorDisplayLib/FancyPlotter.cpp (line 295) <https://git.reviewboard.kde.org/r/125063/#comment58826> You might want to add that "open() opens the dialog modaly (ie. blocks the parent window)", it might be better understood why open - Martin Klapetek On Sept. 9, 2015, 9:09 p.m., Raphael Kugelmann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125063/ > ----------------------------------------------------------- > > (Updated Sept. 9, 2015, 9:09 p.m.) > > > Review request for Plasma. > > > Repository: ksysguard > > > Description > ------- > > Bugfix for Bug 260869 - [steps] System Monitor crashes while changing sensors > > > Diffs > ----- > > gui/SensorDisplayLib/FancyPlotter.cpp > 6c2e8d14e0217c324845dc1b9b34481f3c6be34c > > Diff: https://git.reviewboard.kde.org/r/125063/diff/ > > > Testing > ------- > > Fail test procedure: > 1. create a FancyPlotter View with an Sensor > 2. open the settings for this FancyPlotter view and goto Sensor Tab > 3. add in the MainWindow (in the background) a new Sensor > 4. Close the Setting window by pressing the OK button > --> Crash > > The Bugfix makes the mainwindow not editable while the settings dialog is > open. > Therefore the written test above cannot be performed anymore. > The Fail case cannot be reached anymore. > > > Thanks, > > Raphael Kugelmann > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel