> On 9月 3, 2015, 12:41 a.m., Aleix Pol Gonzalez wrote: > > Good stuff! > > > > +1
Thanks Aleix:) Could I have more comments from any other guys? :) - Takahiro ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124877/#review84772 ----------------------------------------------------------- On 9月 11, 2015, 10:01 p.m., Takahiro Hashimoto wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124877/ > ----------------------------------------------------------- > > (Updated 9月 11, 2015, 10:01 p.m.) > > > Review request for Plasma. > > > Bugs: 351609 > https://bugs.kde.org/show_bug.cgi?id=351609 > > > Repository: plasma-workspace > > > Description > ------- > > Building Plasma5 with Qt 5.6 branch, kstartupconfig5/kdostartupconfig5 > generates corrupted files. > > $HOME/.config/startupconfigfiles > $HOME/.config/startupconfig > > > Diffs > ----- > > startkde/kstartupconfig/kdostartupconfig.cpp 3944c06 > > Diff: https://git.reviewboard.kde.org/r/124877/diff/ > > > Testing > ------- > > works for me. > > 1. execute kstartupconfig5 > 2. check if both files are not corrupted. > > > Updated: rebased with latest and tested with Revision 2 the same test. OK. > > > Thanks, > > Takahiro Hashimoto > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel