> On Sept. 12, 2015, 10:14 a.m., David Edmundson wrote: > > We depend on git master of frameworks in Plasma master quite often, and our > > build instructions for Plasma include frameworks. > > > > Is this causing a problem somewhere?
Well, I just upgraded to newly released frameworks 5.14, which is the required dependency for plasma-workspace and the build failed. At that time, frameworks weren't bumped to 5.15 and the dep couldn't be increased. I wanted to backport the method to my local kconfig build, but David Faure advised me against doing so and instead writing this patch since the class is one liner, so the dep doesn't need to be bumped again. The patch is trivial, and can be reverted once frameworks 5.15 have been released. - Armin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125187/#review85240 ----------------------------------------------------------- On Sept. 12, 2015, 9:38 a.m., Armin K. wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125187/ > ----------------------------------------------------------- > > (Updated Sept. 12, 2015, 9:38 a.m.) > > > Review request for Plasma and David Faure. > > > Repository: plasma-workspace > > > Description > ------- > > KDesktopFile.readMimeTypes(); hasn't made it into Frameworks 5.14, causing > plasma-workspace git master to depend on yet unreleased version of KDE > Frameworks to build. David Faure has suggested to use fix like this one until > at least Frameworks 5.15 have been released. > > I don't have commit access, so someone needs to commit this for me. > > > Diffs > ----- > > applets/icon/plugin/icon_p.cpp 97af67a > > Diff: https://git.reviewboard.kde.org/r/125187/diff/ > > > Testing > ------- > > It builds. > > > Thanks, > > Armin K. > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
