> On Sept. 15, 2015, 12:06 a.m., David Edmundson wrote: > > src/qmlcontrols/kquickcontrolsaddons/eventforge.cpp, line 51 > > <https://git.reviewboard.kde.org/r/125226/diff/1/?file=403304#file403304line51> > > > > why do people need to do this? > > Eike Hein wrote: > It basically triggers the onCanceled handler in MouseArea and > MouseEventListener, and is used to abort mouse handling in applet items when > you enable applet moving via press and hold in the containment. Flickable > does similar things internally for flicking the viewport, but Qt only has > private API for it (which isn't easily made public); this is the closest > approximation using public API.
Don't tell me, tell the .cpp file :) - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125226/#review85410 ----------------------------------------------------------- On Sept. 15, 2015, 5:32 p.m., Marco Martin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125226/ > ----------------------------------------------------------- > > (Updated Sept. 15, 2015, 5:32 p.m.) > > > Review request for KDE Frameworks, Plasma and Eike Hein. > > > Repository: kdeclarative > > > Description > ------- > > EventForge can cancel the half-managed events of child items > in order to implement the move of them with press and hold, > not having the parent and the children battling for the same > press-move-release event sequence. > > API-wise I think it's fine, apart perhaps the EventForge class name > (perhaps MouseEventGrabber is less technically correct, but still more clear?) > > > Diffs > ----- > > src/qmlcontrols/kquickcontrolsaddons/mouseeventlistener.h a62efb7 > src/qmlcontrols/kquickcontrolsaddons/mouseeventlistener.cpp d3321a3 > > Diff: https://git.reviewboard.kde.org/r/125226/diff/ > > > Testing > ------- > > > Thanks, > > Marco Martin > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
