----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125117/#review85813 -----------------------------------------------------------
Ship it! Maybe we just want to remove all this logic. It used to exist because there was no explicit "Disable Baloo button". Now that there is the button, do we want to magically disable Baloo if nothing is going to be indexed? I think so, though I'm not sure. Anyway, ship it. Nice work, and sorry for the delay. - Vishesh Handa On Sept. 22, 2015, 7:24 p.m., Ovidiu-Florin BOGDAN wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125117/ > ----------------------------------------------------------- > > (Updated Sept. 22, 2015, 7:24 p.m.) > > > Review request for Baloo, Plasma and Vishesh Handa. > > > Repository: plasma-desktop > > > Description > ------- > > And simplified the way it searches for the mount points. > > > Diffs > ----- > > kcms/baloo/folderselectionwidget.h 6430b60 > kcms/baloo/folderselectionwidget.cpp 3ad1764 > kcms/baloo/kcm.h 6878e89 > kcms/baloo/kcm.cpp d85f615 > > Diff: https://git.reviewboard.kde.org/r/125117/diff/ > > > Testing > ------- > > Compiled and used. > > > Thanks, > > Ovidiu-Florin BOGDAN > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
