> On Сен. 24, 2015, 3:56 п.п., Martin Klapetek wrote: > > Thanks for the patch. Is it reproducible with anything else? Also, can you > > point me to the ktp code in question? > > > > Thanks
It's [ktp-approver/textchannelapprover.cpp](https://quickgit.kde.org/?p=ktp-approver.git&a=blob&h=b28db461f539c8218b8787ad637c7925ad28b5aa&hb=15c82c42262bc95d014ab65531ede0d97c44a29b&f=src%2Ftextchannelapprover.cpp), TextChannelApprover::onMessageReceived(). I'm not sure where can I test it, since KTp might be the only thing which produces notifications and then tries to reuse it (not sure about it). Any suggestions? If you think it's worth it, I can try write a simple few-line program and try to reproduce it. > On Сен. 24, 2015, 3:56 п.п., Martin Klapetek wrote: > > src/knotification.cpp, lines 429-430 > > <https://git.reviewboard.kde.org/r/125376/diff/1/?file=405175#file405175line429> > > > > {}s around ifs Right, even in one-line patch I made a mistake X_X Old habits die slowly and painfully... - Igor ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125376/#review85875 ----------------------------------------------------------- On Сен. 24, 2015, 3:49 п.п., Igor Poboiko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125376/ > ----------------------------------------------------------- > > (Updated Сен. 24, 2015, 3:49 п.п.) > > > Review request for Plasma and Martin Klapetek. > > > Repository: knotifications > > > Description > ------- > > I've noted a bug when using KDE Telepathy: if I receive 2 new messages, first > creates a new notification, and second is being duplicated (see screenshot > attached; on it I just wrote myself "hello", then "world"). > > Investigation showed following: > * KTp calls KNotification::setText on existing notification > * KNotification starts d->updateTimer, which will update notification in 100 > msec > * KTp call KNotification::sendEvent, which updates notification > * updateTimer expires calling KNotification::update() again, leading to > duplicated DBus message and duplicated notification > > Not sure if there is any bug in BugZilla, but it is 100% reproducible in my > case. > > > Diffs > ----- > > src/knotification.cpp cf09e63 > > Diff: https://git.reviewboard.kde.org/r/125376/diff/ > > > Testing > ------- > > After applying patch it works fine. > > > File Attachments > ---------------- > > The problem > > https://git.reviewboard.kde.org/media/uploaded/files/2015/09/24/161f9955-068a-4b39-85d0-8537b05d9cb2__snapshot22.png > > > Thanks, > > Igor Poboiko > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
