> On Oct. 5, 2015, 1:59 p.m., David Edmundson wrote: > > src/plasmaquick/dialog.cpp, line 156 > > <https://git.reviewboard.kde.org/r/125528/diff/1/?file=409731#file409731line156> > > > > just QGuiApplication::screens() should be fine here.
Hmm, is then there not a regression that we look at screens not in the right "group"? At least I understood the docs that way that you don't get just all screens with virtualSiblings, but I am no expert. - Christoph ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125528/#review86371 ----------------------------------------------------------- On Oct. 5, 2015, 1:41 p.m., Christoph Cullmann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125528/ > ----------------------------------------------------------- > > (Updated Oct. 5, 2015, 1:41 p.m.) > > > Review request for Plasma and Marco Martin. > > > Bugs: 345173 > http://bugs.kde.org/show_bug.cgi?id=345173 > > > Repository: plasma-framework > > > Description > ------- > > Check for nullptr screen > > > Diffs > ----- > > src/plasmaquick/dialog.cpp 8d4f508 > > Diff: https://git.reviewboard.kde.org/r/125528/diff/ > > > Testing > ------- > > As Qt was stupid enough to change the API, we now need to check for nullptr. > > > Thanks, > > Christoph Cullmann > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
