> On Oct. 9, 2015, 8:42 a.m., Marco Martin wrote:
> > I would need to look at the file to see if the stylesheet are all fine. 
> > does it adapt correctly to breeze-dark without need for other svg files?
> 
> Uri Herrera wrote:
>     I made a dark version too. It works fine too. I uploade dmore picture 
> shere: 
> https://plus.google.com/u/0/photos/104418606911164850525/albums/6203529438759412385
> 
> Marco Martin wrote:
>     no, this is not about having a dark version or not, is about being able 
> to change the colors in the svg at runtime. The actual graphics of the dark 
> version should be completely redundant.
>     Pieces of the ui have inverted colors in the lock screen/logout or in 
> plasma mobile, having dynamic colors is the only way to not have that break.
>     plus I'm planning to have a version that follows system colors as well, 
> that works and is possible already in the current theme, is just explicitly 
> disabled.
> 
> Marco Martin wrote:
>     like that one (there using a completely stupid color scheme, but if the 
> theme is well done, in general it just works)
>     http://imgur.com/tEm9icR

Ah, well, that should probably be documented becuase I only knew that it was 
something that was being worked on (use stylesheets) but as I can;t find 
anything about it I just went with what I know works.


- Uri


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125568/#review86527
-----------------------------------------------------------


On Oct. 9, 2015, 8:28 a.m., Uri Herrera wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125568/
> -----------------------------------------------------------
> 
> (Updated Oct. 9, 2015, 8:28 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> SVG elements done from scratch, reused only a small portion of the existing 
> files. Colors now match Breeze colorscheme. Buttons now match widget style. 
> Icons in the system tray are taken from the icon theme. Icons in Kickoff are 
> not monochromatic as only 16px and 22px icons are monochrome in Breeze. 
> Better padding overall for elements. New visual for both task manager widgets 
> that matches the states of the buttons. Checkboxes, raio buttons, sliders and 
> scrollbars now have the colors used in the Breeze colorscheme.
> 
> 
> Diffs
> -----
> 
> 
> Diff: https://git.reviewboard.kde.org/r/125568/diff/
> 
> 
> Testing
> -------
> 
> ![Before](http://i.imgur.com/Cz2JNee.png)
> ![After](http://i.imgur.com/hiZlyrb.png)
> 
> ![Elements after](http://i.imgur.com/uMFsMzp.png)
> ![Elements before](http://i.imgur.com/pIs1CZ2.png)
> 
> 
> Thanks,
> 
> Uri Herrera
> 
>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Reply via email to