----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124980/#review86996 -----------------------------------------------------------
overall looks good to me. Thanks for changing to generating code ;-) components/sessionsprivate/sessionsmodel.cpp (lines 215 - 221) <https://git.reviewboard.kde.org/r/124980/#comment59814> QByteArrayLiteral - Martin Gräßlin On Oct. 17, 2015, 7:59 p.m., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124980/ > ----------------------------------------------------------- > > (Updated Oct. 17, 2015, 7:59 p.m.) > > > Review request for Plasma and Martin Gräßlin. > > > Repository: plasma-workspace > > > Description > ------- > > This way it can be used in the lock screen, user switcher, and a user > switcher plasmoid I'm planning. > > Compared to the one in the lock screen it can also get the user's full name > and avatar, and some other information. > > Perhaps we could also try to have it wait for the screen to actually lock > before switching sessions? > > > Diffs > ----- > > components/CMakeLists.txt 21fc61c > components/sessionsprivate/CMakeLists.txt PRE-CREATION > components/sessionsprivate/qmldir PRE-CREATION > components/sessionsprivate/sessionsmodel.h PRE-CREATION > components/sessionsprivate/sessionsmodel.cpp PRE-CREATION > components/sessionsprivate/sessionsprivateplugin.h PRE-CREATION > components/sessionsprivate/sessionsprivateplugin.cpp PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/124980/diff/ > > > Testing > ------- > > Lists my sessions, allows to switch between them and start new ones. Locking > when creating a new session is missing. > > > Thanks, > > Kai Uwe Broulik > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
