----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125727/ -----------------------------------------------------------
Review request for Plasma. Repository: plasma-workspace Description ------- QWindow.show() doesn't refrect its windowState property which is set by manual. As ksplashqml treats windowState(expected to be set to Qt::WindowFullScreen) we should use QWindow.setVisible(true) instead. At present the ksplashqml view size is adjusted to the screen size by another implementation (syncResizeMode()). We might discuss about handling windowState flag. I think we expect splashscreen is displayed full-screen and handling windowState is correct approach. Diffs ----- ksplash/ksplashqml/splashapp.cpp 8ad4f4d Diff: https://git.reviewboard.kde.org/r/125727/diff/ Testing ------- applied the patch and confirmed that ksplashqml (with/without "--test") shown full-screen. Thanks, Takahiro Hashimoto
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
