----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125774/#review87345 -----------------------------------------------------------
>From my side it looks fine, though I haven't tested yet. lookandfeel/contents/lockscreen/ChangeSession.qml (lines 45 - 58) <https://git.reviewboard.kde.org/r/125774/#comment59981> please add context, otherwise the translators will have a hard time to translate those messages. - Martin Gräßlin On Okt. 24, 2015, 5:48 nachm., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125774/ > ----------------------------------------------------------- > > (Updated Okt. 24, 2015, 5:48 nachm.) > > > Review request for Plasma and Martin Gräßlin. > > > Repository: plasma-workspace > > > Description > ------- > > This migrates the Lock Screen qml from using ksmserver's Session model to the > new one provided by components. > > Changes: > > * It now shows the user avatar and full name in the user switcher > > * It only offers to switch sessions if there are any > > I would like to remove the sessions model stuff from the screenlocker greeter > (given it's unused then and would bitrot), however we probably cannot do this > or else we break 3rd party look and feel packages. > > > Diffs > ----- > > lookandfeel/contents/components/UserSelect.qml 007a118 > lookandfeel/contents/lockscreen/ChangeSession.qml 58974f6 > lookandfeel/contents/lockscreen/LockScreen.qml 3a78a5f > lookandfeel/contents/lockscreen/MainBlock.qml 6d39a86 > > Diff: https://git.reviewboard.kde.org/r/125774/diff/ > > > Testing > ------- > > Switching users (both to other X and TTY) as well as creating a new session > works. > The model does not update, however, meaning if you log in elsewhere the > "Switch session" button won't magically appear while the screen is locked. I > don't think the old model did that either. > > Also, when cancelling the user switch, it will scroll the view back to the > first item so you're not stranded with two buttons with the user scrolled out > of the view with no indication (I think there was a bug report and the code > was there, it just tried to reset the wrong index property) > > > Thanks, > > Kai Uwe Broulik > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
