> On Oct. 26, 2015, 6:46 p.m., David Edmundson wrote: > > shell/panelview.cpp, line 723 > > <https://git.reviewboard.kde.org/r/125451/diff/2/?file=412862#file412862line723> > > > > Why is this connect in showEvent?
Because we don't want to change stuff while the panel is still being set up. > On Oct. 26, 2015, 6:46 p.m., David Edmundson wrote: > > shell/panelview.cpp, line 734 > > <https://git.reviewboard.kde.org/r/125451/diff/2/?file=412862#file412862line734> > > > > this won't work. > > > > X struts are relative to the global work area (i.e all the screens) > > > > if you have a small laptop with a high res external screen, when you > > unplug the external screen you'll need to update the struts of a panel on > > the smaller screen. > > > > This signal wouldn't be emitted in that case. I'm not sure what the > > right signal is. I can make the corona responsible for this then. - Aleix ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125451/#review87448 ----------------------------------------------------------- On Oct. 26, 2015, 6:39 p.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125451/ > ----------------------------------------------------------- > > (Updated Oct. 26, 2015, 6:39 p.m.) > > > Review request for Plasma. > > > Repository: plasma-workspace > > > Description > ------- > > Now that everything's in place in Qt, we can do that. > > It basically removes all the translation layer between KScreen and QScreen. > > NOTE: This can't be merged until Qt 5.6 is a dependency. > > > Diffs > ----- > > CMakeLists.txt 50091ea > shell/CMakeLists.txt e17e4a3 > shell/desktopview.h 867cfdc > shell/desktopview.cpp 42a1f08 > shell/panelview.h 9f8d4ce > shell/panelview.cpp 3317b52 > shell/shellcorona.h b04b102 > shell/shellcorona.cpp 56570b4 > > Diff: https://git.reviewboard.kde.org/r/125451/diff/ > > > Testing > ------- > > Hands-on testing, it's been working quite fluid and I couldn't find a crash. > (There could be crashes, I just didn't find them :D) > > > Thanks, > > Aleix Pol Gonzalez > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel