----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125858/#review87653 -----------------------------------------------------------
Ship it! ok with the patch, but the dataengine should be fixed as well? - Marco Martin On Oct. 29, 2015, 7:20 a.m., Kåre Särs wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125858/ > ----------------------------------------------------------- > > (Updated Oct. 29, 2015, 7:20 a.m.) > > > Review request for Plasma, David Edmundson and Martin Yrjölä. > > > Repository: kdeplasma-addons > > > Description > ------- > > The SystemLoadViewer freezes plasmashell when the systemmonitor data-engine > returns erroneous values. The freeze only happens with the compact bars > selected. > > This patch ensures that the proportions of the loads do not exceed 1. > > This patch should fix BUG: 348385 > > > Diffs > ----- > > applets/systemloadviewer/package/contents/ui/SystemLoadViewer.qml 8023b44 > > Diff: https://git.reviewboard.kde.org/r/125858/diff/ > > > Testing > ------- > > I did run a version of this patch over night that had extra debug printouts > and I got 17 printouts with huge values returned. The limitation of the value > to max 1, prevented freezes. > > > Thanks, > > Kåre Särs > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
