----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125622/#review87738 -----------------------------------------------------------
Sorry I put the wrong review number on the commit for 125662 - Jeremy Whiting On Oct. 15, 2015, 8:12 a.m., David Rosca wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125622/ > ----------------------------------------------------------- > > (Updated Oct. 15, 2015, 8:12 a.m.) > > > Review request for Plasma. > > > Repository: plasma-pa > > > Description > ------- > > As noted in https://git.reviewboard.kde.org/r/125088/, this should fix > acessibility on volume sliders. > This also fixes changing the volume with keyboard (when slider has focus). > > > Diffs > ----- > > applet/contents/ui/ListItemBase.qml 54f6eb0 > src/kcm/package/contents/ui/VolumeSlider.qml da77315 > > Diff: https://git.reviewboard.kde.org/r/125622/diff/ > > > Testing > ------- > > Changing volume in applet still works + it fixes changing volume in kcm (i > broke it with last commit - there is no setVolume() in kcm VolumeSlider). > > > Thanks, > > David Rosca > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
