> On Nov. 5, 2015, 10:31 p.m., Thomas Pfeiffer wrote:
> > Nice feature!
> > There definitely has to be a way to uninstall a Plasmoid, however. Can't we 
> > show an uninstall button when hovering over a Plasmoid in the widget 
> > gallery?
> > 
> > Also, the labeling of the pupop menu when dropping on the desktop is 
> > unfortunate in general, as it is not self-explanatory at all.
> > What are those heading for, anyway? A context menu should only contain only 
> > action items.
> > I know this is a general problem with this menu (which I have not noticed 
> > yet because apparently I never dropped anything on the desktop recently 
> > which opens such a menu), but you should start here by just using a single 
> > entry "Install Wigdet" instead of "Plasma Package" and "Install".
> 
> Heiko Tietze wrote:
>     It makes sense to use the default context menu for drag operations with 
> Move, Copy, Link - and Install in case of plasmoids (I wouldn't just disable 
> this item since it's very rarely used).
>     
>     Users might expect to be able having wallpapers installed via drag and 
> drop and perhaps also ordinary packages.
>     
>     The notification text is too long, redundant and not informative. But 
> that might be the return value from the installation process.
> 
> Kai Uwe Broulik wrote:
>     > It makes sense to use the default context menu for drag operations with 
> Move, Copy, Link
>     
>     How should that work? Where should the thing end up if I move/copy/link? 
> If you have a FolderView containment you should get that menu, I think.
>     > Users might expect to be able having wallpapers installed via drag and 
> drop and perhaps also ordinary packages.
>     
>     At least for wallpapers, I have that planned, also. You can already drop 
> JPEG files and the like and use them as a wallaper, only makes sense to be 
> able to drop wallpaper packages as well. Ordinary packages I'd rather not 
> since we cannot provide this for every package format out there (eg. Kickoff 
> also only allows to uninstall applications via packagekit iirc)
>     > But that might be the return value from the installation process.
>     
>     It is, I'm hoping for an improved API so I can provide a better error 
> message.

>How should that work? Where should the thing end up if I move/copy/link?

The context menu that pops up after drag 'n drop operations should provide the 
Install additonally. Other operations work like for any other file, i.e. just 
move/copy/link the .plasmoid file to the desktop, folder view or whatever.


- Heiko


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125968/#review88067
-----------------------------------------------------------


On Nov. 5, 2015, 8:23 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125968/
> -----------------------------------------------------------
> 
> (Updated Nov. 5, 2015, 8:23 p.m.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> This allows to drop a .plasmoid file on a panel or desktop and have it 
> automatically installed and placed there.
> 
> Video: https://www.youtube.com/watch?v=5MnWnt_u5dU
> 
> 
> Diffs
> -----
> 
>   src/scriptengines/qml/CMakeLists.txt 2aedf0b 
>   src/scriptengines/qml/plasmoid/containmentinterface.cpp 772031f 
> 
> Diff: https://git.reviewboard.kde.org/r/125968/diff/
> 
> 
> Testing
> -------
> 
> Works, as long as the applet is not yet installed
> 
> 1.) How can I properly check the install status? The docs just say "returns a 
> KJob allowing to track installation progress". I don't see a way to check for 
> "applet already installed" (should update existing one if newer?) or 
> "installation failed". In the former case I just want to add the already 
> installed applet
> 
> 1a.) btw since we no longer have a tooltip in the widget explorer, there's no 
> way to uninstall user-installed applets :/ Perhaps a delete button with undo 
> like in the wallpaper selection should be added
> 
> 2.) How can I get the pluginId of the applet? KPackage::metadata() is 
> deprecated. Perhaps the KJob should be able to tell me eventually?
> 
> 3.) How can I get the path to the installed package to get the info for 2.
> 
> 4.) Not sure about linking KNotifications here
> 
> 5.) I want an icon for the action :)
> 
> Please disregard the qDebug()s
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Reply via email to