----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124585/ -----------------------------------------------------------
(Updated Nov. 8, 2015, 6:14 nachm.) Review request for Plasma and KDE Usability. Changes ------- * Migrate to SessionsModel, simplify code * The "New Session" button is always consistently in the bottom left corner Repository: plasma-workspace Description ------- This adds a user switcher dialog borrowing elements from the lock screen and log out dialog. I never understood why KRunner was used for that. It is not yet hooked up to the system (would make KRunner's "switchUser" interface forward that to KSMServer so everybody using it (eg. kickoff) would continue to work without adjustments). To test it run qdbus org.kde.ksmserver /KSMServer openSwitchUserDialog When it opens it defaults to "New Session", from an interaction POV the list view behaves like the one on the lock screen. It locks the screen when switching users only when the user has enabled the lock screen (might need a separate option for that?) That unconditional locking on session switching has turned out to be a major annoyance. Diffs (updated) ----- ksmserver/CMakeLists.txt b4eb9b8 ksmserver/org.kde.KSMServerInterface.xml 3680ed7 ksmserver/server.h 87e46cb ksmserver/server.cpp ffb15d2 ksmserver/switchuserdialog.h PRE-CREATION ksmserver/switchuserdialog.cpp PRE-CREATION lookandfeel/contents/components/UserList.qml 778d8ea lookandfeel/contents/components/UserSelect.qml 5af566d lookandfeel/contents/userswitcher/UserSwitcher.qml e69de29 Diff: https://git.reviewboard.kde.org/r/124585/diff/ Testing ------- Looks pretty, switching to a new or existing session works. Btw, weren't we able to click outside the dialog to dismiss it in 4.x? Seems broken for the logout dialog as well. File Attachments (updated) ---------------- No active sessions https://git.reviewboard.kde.org/media/uploaded/files/2015/11/08/6acd1764-db79-401b-936b-7a6fb5809c5a__userswitchera1.jpg Switch sessions https://git.reviewboard.kde.org/media/uploaded/files/2015/11/08/b21de001-c011-4733-a47f-e2966ac2b955__userswitchera2.jpg Thanks, Kai Uwe Broulik
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
