----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126013/ -----------------------------------------------------------
Review request for Plasma. Repository: plasma-desktop Description ------- The XCB-XKB dependency of plasma-desktop is optional, however kacess depends directly and unconditionally on the xcb/xkb.h header file. This causes the build of plasma-desktop to fail at compile stage if the xkb header is not present. As per the convention in the kcm modules shipped by plasma-desktop, inclusion of the kacess subdirectory is made conditional on XKB being present and properly detected during the cmake configure stage. Diffs ----- CMakeLists.txt 193238a8dcbb2c6e2bda01c390c57ff2ecfebeb0 Diff: https://git.reviewboard.kde.org/r/126013/diff/ Testing ------- Built without xkb header, using kdesrc-build Thanks, Johan Ouwerkerk
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel