> On Nov. 10, 2015, 2:53 a.m., Martin Klapetek wrote: > > By the duplicated function you mean PlasmoidTask::showMenu(int x, int y)? > > That one has only two args and is missing the "run associated application" > > action, which I'm not entirely sure what's it used for. The rest indeed > > looks about the same (though the showMenu could really use some commentary)
yes. the extra arg isn't needed as it refers to "this" in PlasmoidTask. run assoc action I maybe need, I'll double check. Thanks - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125973/#review88210 ----------------------------------------------------------- On Nov. 9, 2015, 10:42 p.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125973/ > ----------------------------------------------------------- > > (Updated Nov. 9, 2015, 10:42 p.m.) > > > Review request for Plasma. > > > Repository: plasma-workspace > > > Description > ------- > > Remove almost completely duplicated function. > One was used for right clicking on expanded items, the other for full compact > items. > > > Diffs > ----- > > applets/systemtray/package/contents/ui/ExpandedRepresentation.qml > a53be6cb0d9fae14e055a6d1381ad11fee0a236e > applets/systemtray/plugin/host.h db6fc567666281c8b2fe81eab085ae4b950bf07d > applets/systemtray/plugin/host.cpp 61e87050826a28409e44c8dac5baebe12e59bf63 > > Diff: https://git.reviewboard.kde.org/r/125973/diff/ > > > Testing > ------- > > > Thanks, > > David Edmundson > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
