> On Nov. 9, 2015, 11:36 p.m., Thomas Pfeiffer wrote: > > Why is that? How is the systray different from other widgets in the panel? > > And if we don't show panel options in the context menu of anything in the > > panel, how does a user get to them? > > > > This is another issue that would be solved by a clear separation between a > > "usage mode" and a "config mode", btw.
Good question. So before we had 3 bits of menu code: one for SNIs one for compact plasmoids one for expanded plasmoids only one of them (expanded plasmoids) showed the panel options menu entry. So definitely something is wrong I went with the logic "the odd one out is the wrong one" sys tray is arguably a bit different as it is already adding an entry "system tray options" so we're already going one level up - but I'm not completely attached to that argument. >And if we don't show panel options in the context menu of anything in the >panel, how does a user get to them? There's the burger menu on the right in all cases anyway. AFAIK you can't turn that one off in the UI. - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125972/#review88207 ----------------------------------------------------------- On Nov. 9, 2015, 10:43 p.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125972/ > ----------------------------------------------------------- > > (Updated Nov. 9, 2015, 10:43 p.m.) > > > Review request for Plasma. > > > Repository: plasma-workspace > > > Description > ------- > > as in "panel options" when systray is in the panel. > > Only one of the formerly two (see https://git.reviewboard.kde.org/r/125973/) > methods did this, so I think it's safe to remove from the one I'm keeping. > > > Diffs > ----- > > applets/systemtray/plugin/protocols/plasmoid/plasmoidtask.cpp > d378be14a4102144079b6a7819208e7bbd9b1bb7 > > Diff: https://git.reviewboard.kde.org/r/125972/diff/ > > > Testing > ------- > > > Thanks, > > David Edmundson > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
