----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126166/#review88799 -----------------------------------------------------------
Ship it! Ship It! - Sebastian Kügler On Nov. 25, 2015, 1:54 p.m., Marco Martin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126166/ > ----------------------------------------------------------- > > (Updated Nov. 25, 2015, 1:54 p.m.) > > > Review request for Plasma, andreas kainz and Uri Herrera. > > > Repository: breeze-icons > > > Description > ------- > > unfortunately the diff was about 35 megabytes, so was too big for reviewboard > little mind ;) > a tarball of the modified icons can be found at > http://notmart.org/misc/breeze-icons.tar.bz2 > this changes the monochrome breeze icons (other icons are untouched) to use > stylesheets instead of hardcoded colors, at least with text color for the > black bits, background for the light bits. > This is kinda needed for icons loaded in plasma (even tough some basic icons > in the plasma theme systray and actions are still needed, less duplication > would be needed) > Will be needed a bit more stringently in plasma mobile, where the plasma > theme is used as theme for applications (and probably some effects will be > needed like changing icons from black to white on the fly) > > This change is not supposed to change the look of any icon anywhere: for > desktop applications all of them should look *exactly* the same as they did > (please doublecheck this ;)) > > > Diffs > ----- > > CMakeLists.txt 886ab74 > > Diff: https://git.reviewboard.kde.org/r/126166/diff/ > > > Testing > ------- > > > Thanks, > > Marco Martin > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
