> On Sept. 15, 2015, 9:33 p.m., Vishesh Handa wrote: > > Maybe we could just add this to our `IndexerConfig` class so that users of > > our API don't need to know about dbus interfaces? Specially since I'm not > > too keen on maintaining API comatibility in the dbus interface. > > Pinak Ahuja wrote: > You mean adding a public method in IndexerConfig to update config? > updateConfig in mainhub also calls > FileWatch::updateIndexedFoldersWatches() > > Vishesh Handa wrote: > Yup. Add a method in `IndexerConfig`. Maybe refresh or reload? > > Vishesh Handa wrote: > Ping. I think we can now use the new APIs in IndexerConfig. > > Pinak Ahuja wrote: > how do we handle killing baloo without dbus? Do I add an API for that as > well in IndexerConfig? > > Vishesh Handa wrote: > well, we could just give it a signal to quit or use the 'quit' dbus > method directly on '/'. IndexerConfig does not seem like the best place for a > method to control the state of the indexer.
Wasn't,removing reliance of the kcm on D-bus interfaces the whole point of adding the refresh API to the IndexerConfig. If we still use the D-Bus quit method that sort of invalidates the change. The only other way to kill baloo that I can think of is calling kill using QProcess, but that would be ugly. Seems like can't do away with the D-Bus reliance completely. I'll update the patch keeping the quit part same and use the IndexerConfig API for refresh. - Pinak ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125129/#review85462 ----------------------------------------------------------- On Sept. 10, 2015, 5:56 a.m., Pinak Ahuja wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125129/ > ----------------------------------------------------------- > > (Updated Sept. 10, 2015, 5:56 a.m.) > > > Review request for Plasma and Vishesh Handa. > > > Repository: plasma-desktop > > > Description > ------- > > Also generate interface from XML > > > Diffs > ----- > > kcms/baloo/CMakeLists.txt 7415289 > kcms/baloo/kcm.cpp d85f615 > > Diff: https://git.reviewboard.kde.org/r/125129/diff/ > > > Testing > ------- > > > Thanks, > > Pinak Ahuja > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
