----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126246/#review89314 -----------------------------------------------------------
+1 I don't know this package, but the change "looks ok" to me. If nobody objects within - lets say 3 days - then just ship it. - Mark Gaiser On dec 4, 2015, 6:23 p.m., Marco Martin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126246/ > ----------------------------------------------------------- > > (Updated dec 4, 2015, 6:23 p.m.) > > > Review request for KDE Frameworks and Plasma. > > > Repository: kpackage > > > Description > ------- > > this, referred to https://git.reviewboard.kde.org/r/126244/ tests that adding > or removing a file definition depending on the path (and whatever criteria, > like metadata contents) works. since is already done in several places has to > work correctly > > > Diffs > ----- > > autotests/packagestructuretest.h de2038e > autotests/packagestructuretest.cpp 4784bfd > > Diff: https://git.reviewboard.kde.org/r/126246/diff/ > > > Testing > ------- > > > Thanks, > > Marco Martin > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
