> On Dec. 4, 2015, 4:28 p.m., David Edmundson wrote: > > src/plasma/private/packages.cpp, line 128 > > <https://git.reviewboard.kde.org/r/126244/diff/1/?file=420970#file420970line128> > > > > Having the content structure change when you load a specific package is > > going to result in weird behaviour. > > > > package.files() should be usable from just the structure. > > Marco Martin wrote: > do you think so? I can make this always work but i think is more correct > to have the file definition only valid in containments. > this is already used for some things, like fallback packages (like custom > shells that fall back onthe desktop shell) and seems to be fine. > what changes is that filePath would change between resolving something > and just failing in different packages. > > perhaps some more autotests in kpackage to check this is not having weird > side effects? > > David Edmundson wrote: > Right, but I said .files() will miss something if used without a path and > you've responded with something about filePath which is completely different. > > Marco Martin wrote: > true, that wasn't never really tought to matter much (for wallpaper > packages pretty much the same thing happens, file definitions change > depending from what's in the package). > if you think it's important, i can add it unconditionally. would just > seems weird that this would be available for applets as well > > David Edmundson wrote: > I'm not too fussed, I just wanted you to have considered it and any > possible consequences. > > Ship it > > Marco Martin wrote: > I didn't see particular consequencies, but yeah, if you can find any > please shout any moment, can always be changed :) > > Marco Martin wrote: > uh! idea:) maybe containment packages may be yet another subclass of the > package structure with that file more, so it doesn't do weird things when the > path changes
gah, nevermind, since the package is loaded in the applet ctor, isContainment() doesn't work yet - Marco ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126244/#review89128 ----------------------------------------------------------- On Dec. 4, 2015, 6:24 p.m., Marco Martin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126244/ > ----------------------------------------------------------- > > (Updated Dec. 4, 2015, 6:24 p.m.) > > > Review request for Plasma. > > > Repository: plasma-framework > > > Description > ------- > > the CompactApplet file from the shell package defines the behavior of the > poopup applets in the panel (it implements an internal dialog and all that > jazz) > implementing a simplified systray(both the one for the phone and a separate > one for the desktop), i noticed that a containment may have different ideas > on how to expand an applet: the systray would have for instance a single > popup dialog and put all of its applet full representtions in the same Dialog > , this lets containment representation to override that file (*if* won't get > abused, that's the only thing makes me a bit on the fence about this) > It would make possible also fairly different designs that have been proposed > in the past, such as the bug sidebar similar to the "charm bar" > > > Diffs > ----- > > src/plasma/private/packages.cpp c04d36d > src/plasma/private/packages_p.h a7c4cb1 > src/plasmaquick/appletquickitem.cpp efe8611 > src/plasmaquick/private/appletquickitem_p.h 79c1a2e > > Diff: https://git.reviewboard.kde.org/r/126244/diff/ > > > Testing > ------- > > > Thanks, > > Marco Martin > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
