----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126438/#review89812 -----------------------------------------------------------
Could you attach before/after screenshots, please? - Sebastian Kügler On Dec. 20, 2015, 9:12 p.m., Artur Puzio wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126438/ > ----------------------------------------------------------- > > (Updated Dec. 20, 2015, 9:12 p.m.) > > > Review request for Plasma. > > > Bugs: 356946 > https://bugs.kde.org/show_bug.cgi?id=356946 > > > Repository: plasma-desktop > > > Description > ------- > > As discribed in the bug report: when users has a avatar it's shown in sound > kcm in "Speaker Placement and Testing", but it's not resized. (e.g. If it is > a 1000x1000 image it takes 1000x1000px on screen.) This simple patch forces > maximum size of `KIconLoader::SizeHuge` what is the same as default icon size. > Aspect ratio isn't preserved, but please note that in many other places it's > also assumed that avatar is a square. > > > Diffs > ----- > > kcms/phonon/audiosetup.cpp 4bdba69 > > Diff: https://git.reviewboard.kde.org/r/126438/diff/ > > > Testing > ------- > > Installed patched version. Checked visually sound kcm on account with avatar > and on account without an avatar. > > > Thanks, > > Artur Puzio > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
