----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126524/#review90132 -----------------------------------------------------------
sddmauthhelper.cpp (line 71) <https://git.reviewboard.kde.org/r/126524/#comment61732> I don't like how we write into /usr/ I know the conf.user does already, but it's an incredibly broken concept on the SDDM side that should get fixed at some point. We should write to /var/ somewhere I think That's a task for another day. sddmauthhelper.cpp (line 74) <https://git.reviewboard.kde.org/r/126524/#comment61733> Ideally we should check the *calling* user can read this file, as you technically have a security bug. Otherwise I could just select /etc/shadow as my background and suddenly it's available world readable. A distro/admin could theoretically set polkit up to allow any users to change the SDDM wallpaper. though TBH it'd never happen. Polkit-Qt has that information available. KAuth does not seem to publicly. sddmauthhelper.cpp (line 77) <https://git.reviewboard.kde.org/r/126524/#comment61731> the file could have changed regardless of whether the name has, like if I edit it in krita or something. Unless you want to compare mtimes, you may as well just copy it everytime. - David Edmundson On Dec. 26, 2015, 1:20 p.m., Joshua Noack wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126524/ > ----------------------------------------------------------- > > (Updated Dec. 26, 2015, 1:20 p.m.) > > > Review request for Plasma and David Edmundson. > > > Repository: sddm-kcm > > > Description > ------- > > For some reason sddm cannot handle absolute file paths to wallpapers > and also needs the wallpaper to be readable by others. > > This is fixed by copying the wallpaper to the root directory of the > selected theme. > > On save the sddmauthhelper copies the background from the absolute path > into the theme directory and sets the "background" key of the > theme.user.conf to the copied file. If previously a different background was > set it is removed beforehand. > > > Diffs > ----- > > sddmauthhelper.cpp 648b24c77e7570641d454fca9d121709a622bc36 > src/themeconfig.cpp bdd6dd29fd8eb052e2f2b2239b0c46ebbebec88c > > Diff: https://git.reviewboard.kde.org/r/126524/diff/ > > > Testing > ------- > > Copies and removes backgrounds as intended. > The wallpaper is shown in sddm. > > > Thanks, > > Joshua Noack > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel