> On Jan. 1, 2016, 8:18 p.m., Thomas Pfeiffer wrote:
> > In which cases is no thumbnail available?
> 
> Kai Uwe Broulik wrote:
>     In some cases when the window is minimized.
>     
>     I think now that we stop redirecting windows when the tooltip hides, 
> probably whenever a window is minimized, as we won't have a temporary pixmap 
> at that point anymore.
>     
>     (If you enable "Keep thumbnails for all windows (breaks minimization)" 
> you will always have thumbnails, and probably in Wayland, once we support 
> that, too)

Hm ok.
What is the benefit of not showing a tooltip? I mean yes, it's not very useful 
without a thumbnail, but I'm not sure if it's better to break consistency than 
it is to show a not useful tooltip...


- Thomas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126591/#review90417
-----------------------------------------------------------


On Jan. 1, 2016, 6:38 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126591/
> -----------------------------------------------------------
> 
> (Updated Jan. 1, 2016, 6:38 p.m.)
> 
> 
> Review request for Plasma, KDE Usability and Eike Hein.
> 
> 
> Bugs: 332003
>     https://bugs.kde.org/show_bug.cgi?id=332003
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> When no window thumbnail is available, the tooltip will be hidden. In case of 
> multiple thumbnails (grouping) the thumbnail fallback will be still shown to 
> ensure a unified look and allow closing individual windows in a group through 
> the tooltip.
> 
> I could not just visible: thumbnailAvailable the preview as then it will 
> disable itself and never attempt again to grab a thumbnail.
> 
> 
> Diffs
> -----
> 
>   applets/taskmanager/package/contents/ui/ToolTipDelegate.qml 972dd62 
> 
> Diff: https://git.reviewboard.kde.org/r/126591/diff/
> 
> 
> Testing
> -------
> 
> Works.
> 
> 
> File Attachments
> ----------------
> 
> single window
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/01/01/f0b63d68-b3e1-44dd-b4d2-43b164de7954__tooltipwithsingle.jpg
> multiple windows (one without preview)
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/01/01/e775eab1-9fe3-4f9a-bc18-4db75d36cca2__tooltipwithmultiple.jpg
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Reply via email to