----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126463/#review90530 -----------------------------------------------------------
Ship it! Ship It! - Marco Martin On Dec. 31, 2015, 6:47 p.m., Martin Klapetek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126463/ > ----------------------------------------------------------- > > (Updated Dec. 31, 2015, 6:47 p.m.) > > > Review request for KDE Frameworks and Plasma. > > > Repository: plasma-framework > > > Description > ------- > > Adds new property available as Plasmoid.toolTipItem that allows > to set a full custom item as the tooltip. > > The main motivation is to have a custom Item tooltip for digital > clock to properly format the list of timezones (version of > https://git.reviewboard.kde.org/r/124047/). Adding a custom > PlasmaCore.ToolTipArea to the compact representation does not > work well because then it's a ToolTipArea nested inside another > ToolTipArea (from CompactApplet.qml), this causes a sliding effect > as it changes visual parents when hovering. > > I dunno if this could perhaps be fixed, but seems redundant to have > two ToolTipAreas anyway, so instead this exposes the main applet's > ToolTipArea's mainItem property through Plasmoid.toolTipItem which > the appelts can use to set a custom item. > > This has a part2 patch which goes of plasma-desktop: > https://git.reviewboard.kde.org/r/126464/ > > > Diffs > ----- > > src/scriptengines/qml/plasmoid/appletinterface.h 40016b1 > src/scriptengines/qml/plasmoid/appletinterface.cpp 60b7fa5 > > Diff: https://git.reviewboard.kde.org/r/126463/diff/ > > > Testing > ------- > > I can have custom tooltip item in digital clock without any artifacts > while all other applets still have correct tooltips. > > > Thanks, > > Martin Klapetek > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
