> On Dec. 15, 2015, 2:29 p.m., Martin Gräßlin wrote: > > applets/clipboard/contents/ui/clipboard.qml, line 69 > > <https://git.reviewboard.kde.org/r/126356/diff/1/?file=422789#file422789line69> > > > > this is not the actual size of the systray, but a hardcoded value which > > might match (or not) the size of systray. > > > > As the motivation sounds correct to me I suggest to find a way to > > actually use the size of systray. Experts around? > > andreas kainz wrote: > it doesn't have to have the same size than in the system tray popup. I > only want to reduce the minimum height so that the minimum height would be at > least the height of the popup. it's only a preset value. you don't have to > investigate to much time. use a number would be ok. and it doesn't matter > what would be the minimum size the user have to change the plasmoid size by > themself at the desktop so it is not a predefinition. > > andreas kainz wrote: > would be also ok to use the system tray size but where is the system tray > size defined? > > David Edmundson wrote: > FWIW, the size of the system tray is defined in main.qml as > height: units.gridUnit * 14 > width: units.gridUnit * 24.5 (yes, really) > > However, no other applets match the system tray, and there's no > conceptual reason this has to. > > The minimum size is effectively an arbitrary amount that changes per > plasmoid, and it should be the smallest size one can reasnobly show all the > contents. > I'd say this patch is good as-is. > > andreas kainz wrote: > thanks David I will push this request asap
Also pay attention that the popup size is sensible when the plasmoid is in the panel but outsude the systray - Marco ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126356/#review89547 ----------------------------------------------------------- On Jan. 9, 2016, 9:54 p.m., andreas kainz wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126356/ > ----------------------------------------------------------- > > (Updated Jan. 9, 2016, 9:54 p.m.) > > > Review request for Plasma and Heiko Tietze. > > > Repository: plasma-workspace > > > Description > ------- > > if you use clipboard on the desktop the minimum window height is heigher than > you use clipboard from the panel (drop down window). As the user can define > the width and height for the desktop plasmoid the minimum allowed height > should be at least the same than the drop down window in the panel. so I > change the minimumHeig to 16. > > > Diffs > ----- > > applets/clipboard/contents/ui/clipboard.qml 97230c1 > > Diff: https://git.reviewboard.kde.org/r/126356/diff/ > > > Testing > ------- > > > File Attachments > ---------------- > > old before with 26 min height > > https://git.reviewboard.kde.org/media/uploaded/files/2015/12/15/cdc4e222-a954-4f92-816f-521f35aab7c7__clipboard-alt_.png > new after with 16 min height > > https://git.reviewboard.kde.org/media/uploaded/files/2015/12/15/50773744-a980-4091-8ef2-7eec516cb597__clipboard-new_.png > screenshot > > https://git.reviewboard.kde.org/media/uploaded/files/2016/01/09/566b420b-df44-44d4-86b3-b9f2d441aed8__clipboardMinimumSize.png > > > Thanks, > > andreas kainz > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
