----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126732/#review91010 -----------------------------------------------------------
CMakeLists.txt (line 29) <https://git.reviewboard.kde.org/r/126732/#comment62166> suggestion: add the find(plymouth) to toplevel and make the add_subdirectory in the if also please add something to the feature info - Martin Gräßlin On Jan. 13, 2016, 3:27 p.m., Jonathan Riddell wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126732/ > ----------------------------------------------------------- > > (Updated Jan. 13, 2016, 3:27 p.m.) > > > Review request for Plasma. > > > Repository: breeze > > > Description > ------- > > a plymouth theme for breeze > > based on kubuntu theme, it's one image with a fading in and out glow > also a 16 bit fallback which is just the static k logo > some cmake to look for the current plymouth theme diretory which could do > with testing on other distros > it doesn't try to set it as default theme or run update-initramfs, I think > that can only be done by packagers > suggestions for artwork welcome but changing the functionality (fade in and > out glow) is not something I have the knowledge or time for > I've not included a text fallback theme, the plymouth text theme seems very > limited in functionality and the ubuntu-text theme is presumably distro > specific > > http://weegie.edinburghlinux.co.uk/~jr/tmp/out-3.ogv > > > Diffs > ----- > > CMakeLists.txt cdcc46e > cmake/FindPlymouth.cmake PRE-CREATION > plymouth/CMakeLists.txt PRE-CREATION > plymouth/breeze/README PRE-CREATION > plymouth/breeze/breeze.grub PRE-CREATION > plymouth/breeze/breeze.plymouth.in PRE-CREATION > plymouth/breeze/breeze.script PRE-CREATION > plymouth/breeze/images/16bit/dot.png PRE-CREATION > plymouth/breeze/images/16bit/logo.png PRE-CREATION > plymouth/breeze/images/16bit/progress-rect.png PRE-CREATION > plymouth/breeze/images/16bit/text-input.png PRE-CREATION > plymouth/breeze/images/dot.png PRE-CREATION > plymouth/breeze/images/logo-glow.png PRE-CREATION > plymouth/breeze/images/logo.png PRE-CREATION > plymouth/breeze/images/source.svgz PRE-CREATION > plymouth/breeze/images/text-input.png PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/126732/diff/ > > > Testing > ------- > > installed this > set default.plymouth link to point to breeze.plymouth > install plymouth-x11 > sudo plymouthd --debug --tty=`tty` --no-daemon > sudo plymouth show-splash > pretty K blinks > > > Thanks, > > Jonathan Riddell > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
