> On Jan. 13, 2016, 9:52 a.m., Heiko Tietze wrote: > > Yes, this KCM is not designed according the HIG. It could look like this > > http://i.imgur.com/TVAZBFl.png. Enhancement idea to the existing HIG is a > > horizontal splitter left of "more" that allows to enlarge either the upper > > area to see more than just a few items in the list or to have more space > > for the advanced options. > > About the content I wonder why someone would want to change the cursor at > > this point of the login. And User would be some kind of restriction > > allowing only a range of users to login, if I get this right. Makes not > > much sense to me, however. But anyway, it would be added below the other > > stuff - my mockup cuts the content there for lazyness purpose :-). > > > > A remark regarding the existing KCM: it takes a lot of space and probably > > I'm not the only one who tries to resize the left part. My suggestion is to > > add a vertical splitter. And maybe the right part for customization could > > be smaller by default. > > > > PS: KCMs should indicate if the execution needs elevated user rights. No > > idea how at the moment.
thanks for your comment I like your KCM Style when I know more about cpp and qml I will come back and look that I can make the SDDM KCM like you wrote. - andreas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126730/#review90988 ----------------------------------------------------------- On Jan. 13, 2016, 7:50 p.m., andreas kainz wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126730/ > ----------------------------------------------------------- > > (Updated Jan. 13, 2016, 7:50 p.m.) > > > Review request for Plasma and Heiko Tietze. > > > Repository: sddm-kcm > > > Description > ------- > > remove the webpage and the author in the overview cause this is shown in the > preview section. > > > Diffs > ----- > > src/themesdelegate.cpp 1b528a0 > src/ui/advanceconfig.ui e7fcb97 > src/ui/themeconfig.ui 33cc685 > > Diff: https://git.reviewboard.kde.org/r/126730/diff/ > > > Testing > ------- > > after this cleanup there is one point open but therefore I need someone with > real coding skills. > > KCM HIG > https://community.kde.org/KDE_Visual_Design_Group/System_Settings_Application > > don't use tabs -> add an more button. > > So you have an select area and an preview area as in my point of view the > Auto Login is an "standard setting" I would add the auto login section on > bottom of the select area. > On the bottom page you have an botton > - use userdefined background > - advanced setting > - import from file (now not available) > - import from GHNS (now not available) > > > File Attachments > ---------------- > > sddm-kcm.png > > https://git.reviewboard.kde.org/media/uploaded/files/2016/01/13/483cf282-99b2-4c26-ab51-0d415d3fdf5e__sddm-kcm.png > > > Thanks, > > andreas kainz > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
