> On Jan. 14, 2016, 12:22 p.m., andreas kainz wrote:
> > I have no problems to optimzie the svg files BUT my problem with the svg 
> > files is that they become more complex all the time last time the 
> > stylesheet, now optimization, ....
> > 
> > I love scripts BUT it would be awesome for us to have this scripts before 
> > an distribution build there packages. In git keep it as simple as possible 
> > and when an distro will use the icons use therefore an script (check if the 
> > stylesheets fit, compress, make png files, ....)
> 
> Aleix Pol Gonzalez wrote:
>     That's also the reason why I did it like this. This script doesn't need 
> to be run by the icon designer himself, it can be ran by the release manager 
> before creating the tarballs (or anyone else for that matter).
>     
>     I don't think it's a problem having non-optimized svgs in git, but we 
> should provide users whatever is easier to execute when we release.

If we run this only on releases, it means that typically no developer uses the 
final result of the icons. (I run master all the time, it's usually a pure 
coincidence if I run an actual release on my laptop. If the icons only get 
compressed or optimized right before a release, that means that I've run 
unoptimized svgs, different from what our users end up using, which may yield 
different results.)


- Sebastian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126740/#review91064
-----------------------------------------------------------


On Jan. 14, 2016, 3 a.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126740/
> -----------------------------------------------------------
> 
> (Updated Jan. 14, 2016, 3 a.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: breeze-icons
> 
> 
> Description
> -------
> 
> Dirk's review (https://git.reviewboard.kde.org/r/126738/) gave me the idea 
> that right now we're serving right away the svg's from inkscape and there's 
> room for improvement, potentially.
> 
> This patch just introduces a script that optimizes the svg's using `svgo`.
> 
> More could be done, like using gzip files, we can look into that if anyone's 
> interested. In fact, we used to use svgz for the icons, I wonder why that 
> changed. 
> 
> This will change the files in-place rather than as a build step, which is 
> what I considered first. The process to run svgo on every file was about 30 
> minutes to 1h on my system, so I doubt it's really desirable.
> 
> A reduced file size is important because it will greatly reduce disk IO, 
> which is a bottle-neck we have.
> 
> 
> Diffs
> -----
> 
>   optimize-svg.sh PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/126740/diff/
> 
> 
> Testing
> -------
> 
> ```
> kde-devel@oliver:~/frameworks/breeze-icons (master)$ du -sh icons icons-dark/
> 32M     icons
> 32M     icons-dark/
> 
> #run the script
> 
> kde-devel@oliver:~/frameworks/breeze-icons (master)$ du -sh icons icons-dark/
> 17M     icons
> 17M     icons-dark/
> ```
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Reply via email to