Hi Weng Xeutian, Any ideas on the below mentioned issue?
On Tue, Jan 19, 2016 at 8:09 PM, Rajeesh K V <rajeeshknamb...@gmail.com> wrote: > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126807/ > > On January 19th, 2016, 6:35 p.m. UTC, *Rajeesh K V* wrote: > > I must admit I don't understand the root cause or how m_connection could be > null, but as this fixes the crash - ship it. > > On January 19th, 2016, 6:43 p.m. UTC, *Andreas Cord-Landwehr* wrote: > > If I am not mistaken, the root cause is the following:* XLibTouchpad has a > member variable m_touchpadOffAtom > * this variable is created by the default constructor that sets the > connection to 0 > * no m_touchpadOffAtom.intern(...) call is performed to set the connection, > so it remains 0 > The question now for me is, what are the correct parameters for > m_touchpadOffAtom.inter(...). On the one hand it should be m_connection, on > the other hand I do not know what the parameter "name" should name. The > correct position would be IMO > plasma-desktop/kcms/touchpad/src/backends/x11/xlibtouchpad.cpp line 266 to > make this call. > > Ok, I see the issue now. > The actual backends - libinput and synaptics sets their m_touchpadOffAtom > with respective properties. The new class XlibTouchpad does not initialize > its m_touchpadOffAtom in constructor. I'm not sure with what property it > should be initialized with. Adding Weng Xeutian for more details. > > > - Rajeesh > > On January 19th, 2016, 9:24 a.m. UTC, Andreas Cord-Landwehr wrote: > Review request for Plasma and Alexander Mezin. > By Andreas Cord-Landwehr. > > *Updated Jan. 19, 2016, 9:24 a.m.* > *Bugs: * 357907 <https://bugs.kde.org/show_bug.cgi?id=357907> > *Repository: * plasma-desktop > Description > > This is an attempt to fix the crash reported at > https://bugs.kde.org/show_bug.cgi?id=357907. > Yet, I am neither familiar with the code nor with using XCB. So I cannot > judge if this is only a workaround or a proper fix. > > Testing > > Solves the crashes for me. > > Diffs > > - kcms/touchpad/src/backends/x11/xcbatom.cpp (06f7f52) > > View Diff <https://git.reviewboard.kde.org/r/126807/diff/> > -- Rajeesh http://rajeeshknambiar.wordpress.com
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
