> On Jan. 22, 2016, 6:11 p.m., Martin Gräßlin wrote: > > CMakeLists.txt, lines 19-23 > > <https://git.reviewboard.kde.org/r/126843/diff/1/?file=435230#file435230line19> > > > > on syntax: else and endif don't need to repeat the condition any more. > > Also we tend to use the lower case variants nowadays. > > > > on the feature: maybe better use add_feature_info and add it to the > > feature list as a required one. > > Armin K. wrote: > I was getting a syntax error without the conditional in else and endif > statements. I'll try with lowercase ones. Thanks.
Still the same if I leave (SOCAT_EXECUTABLE) in else and endif statements (now lowercase) => Parse error. Expected "(", got newline with text " This is cmake-3.4.2 - Armin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126843/#review91445 ----------------------------------------------------------- On Jan. 22, 2016, 2:58 p.m., Armin K. wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126843/ > ----------------------------------------------------------- > > (Updated Jan. 22, 2016, 2:58 p.m.) > > > Review request for Plasma and Martin Klapetek. > > > Repository: kwallet-pam > > > Description > ------- > > Currently, kwallet-pam is only usable when used in combination with plasma5, > becaue the code that connects PAM created socket to kwalletd is in startkde > script. > > Move that code into kwallet-pam itself and add an autostart desktop file so > it can be used in plasma and outside of plasma (ie, gnome). Also add a check > for socat executable, which is required to connect to the socket. > > > Diffs > ----- > > CMakeLists.txt 8bd526e > pam_kwallet_init PRE-CREATION > pam_kwallet_init.desktop.cmake PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/126843/diff/ > > > Testing > ------- > > Works in both KDE Plasma and GNOME. Previously, it only worked in KDE Plasma, > I was still asked for password in GNOME. > > > Thanks, > > Armin K. > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel