> On Feb. 2, 2016, 9:22 a.m., Marco Martin wrote: > > hmm, i don't think i like the back/forward buttons both at the right, it > > looked more nicely symmetric before > > Kai Uwe Broulik wrote: > It also reduces mouse travel :) Placing the "Previous" button left of the > month name would look strange. Not a huge fan of having them where they > originally were; the ToolButtons wouldn't fit size- and style-wise. > > Sebastian Kügler wrote: > FWIW, I'm quite happy with it, visually. :)
btw, I'm happy with the explanations, +1 from me ;) - Marco ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126960/#review91926 ----------------------------------------------------------- On Feb. 4, 2016, 11:19 p.m., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126960/ > ----------------------------------------------------------- > > (Updated Feb. 4, 2016, 11:19 p.m.) > > > Review request for Plasma and KDE Usability. > > > Bugs: 336124, 348362 and 358536 > http://bugs.kde.org/show_bug.cgi?id=336124 > http://bugs.kde.org/show_bug.cgi?id=348362 > http://bugs.kde.org/show_bug.cgi?id=358536 > > > Repository: plasma-framework > > > Description > ------- > > This removes the custom label-based triangles and replaces them with proper > ToolButtons using proper icons. It also adds a "Today" button to return to > the current day. Also, tooltips that reflect the actual action ("Previous > Month", "Previous Year", "Previous Decade", depending on the zoom level) were > added. > > > Diffs > ----- > > src/declarativeimports/calendar/qml/DaysCalendar.qml 3ab16eb > src/declarativeimports/calendar/qml/MonthView.qml c876e3b > > Diff: https://git.reviewboard.kde.org/r/126960/diff/ > > > Testing > ------- > > Works. > > The weekday names look a bit awkward now > > > File Attachments > ---------------- > > Screenshot > > https://git.reviewboard.kde.org/media/uploaded/files/2016/02/01/a065dfcf-ca75-4d50-81aa-4d725245344e__Screenshot_20160201_234605.png > How about this? > > https://git.reviewboard.kde.org/media/uploaded/files/2016/02/04/d80b6161-3da3-4669-ba7c-19f62edbf542__Screenshot_20160205_001739.png > How about this? #2 > > https://git.reviewboard.kde.org/media/uploaded/files/2016/02/04/73f2ada9-48cd-4b22-8ef2-5d37f2238442__Screenshot_20160205_001754.png > > > Thanks, > > Kai Uwe Broulik > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
