----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127120/#review92627 -----------------------------------------------------------
I'm against complicating the effect by adding a config to it, but leave it to Marco to decide. - Martin Gräßlin On Feb. 21, 2016, 10:31 a.m., David Rosca wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127120/ > ----------------------------------------------------------- > > (Updated Feb. 21, 2016, 10:31 a.m.) > > > Review request for Plasma. > > > Repository: kwin > > > Description > ------- > > Disabling both animations makes the effect look like the old Plasma tooltip > animation. > Also don't animate when geometry didn't change + don't skip small steps as > resize may happen in steps so we must animate all of them. > > > Diffs > ----- > > effects/morphingpopups/package/contents/code/morphingpopups.js ce6ad86 > effects/morphingpopups/package/contents/config/main.xml PRE-CREATION > effects/morphingpopups/package/contents/ui/config.ui PRE-CREATION > effects/morphingpopups/package/metadata.desktop f9b192c > > Diff: https://git.reviewboard.kde.org/r/127120/diff/ > > > Testing > ------- > > Changing config from KCM needs KWin restart because even though > `configChanged` is emitted, `readConfig` returns the old values (bug, or am I > doing something wrong?). > > > Thanks, > > David Rosca > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
