> On Feb. 20, 2016, 5:51 nachm., Andreas Hartmetz wrote: > > Interesting! > > I have a few local patches like this that I haven't pushed, because > > applications that don't need to be restored by the session manager don't > > care whether they are killed before they are saved for sesson restore, > > right? I had a suspicion that something might still be wrong which is why I > > still have those patches, waiting to push them in case they turn out to be > > useful :) > > Of course, in the cancelled logout scenario, one does care about > > applications getting killed too early and this fixes it. > > This one is yours, I'll push the other ones. > > Wolfgang Bauer wrote: > Well, actually I want to thank *you* very much for taking care about the > general session management issues, investigating and pushing that "fix" to Qt > 5.6. :) > > Just one additional question: should I commit this to the 5.5 branch as > well or only master? > It only has effect with Qt 5.6, but according to the release schedule > this should be released earlier than Plasma 5.6. > > Andreas Hartmetz wrote: > Better ask somebody who knows Plasma better... the answer is probably yes > but I'm not sure. > > Sebastian Kügler wrote: > I'd go for 5.6 (master, currently), there's potential for regressions and > we should give it a wider round of testing, first.
Ok. Btw, it seems Andreas Hartmetz already did commit this as well together with some other changes: https://quickgit.kde.org/?p=plasma-workspace.git&a=commitdiff&h=b5e814a7b2867914327c889794b1088027aaafd6&hp=724bd005b9b3ae0300fdae40483effcd02c192b3 So I'll just mark this as submitted. - Wolfgang ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127125/#review92583 ----------------------------------------------------------- On Feb. 20, 2016, 3:51 nachm., Wolfgang Bauer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127125/ > ----------------------------------------------------------- > > (Updated Feb. 20, 2016, 3:51 nachm.) > > > Review request for Plasma and Andreas Hartmetz. > > > Bugs: 349805 > https://bugs.kde.org/show_bug.cgi?id=349805 > > > Repository: plasma-workspace > > > Description > ------- > > Currently plasmashell is closing too early on logout, so if the logout is > cancelled there will be no usable desktop any more. > This fixes it by disabling Qt's fallback session management that closes all > application windows in response to the session management's save state > request when Qt 5.6 or later is in use. > > > Diffs > ----- > > shell/main.cpp 49ea484 > > Diff: https://git.reviewboard.kde.org/r/127125/diff/ > > > Testing > ------- > > Have a kwrite window with unsaved changes open and logout. > Kwrite will warn the user about the unsaved changes. > > Previously, the desktop disappeared while kwrite's warning dialog was > displayed, and was gone even if the user clicked "Cancel" to abort the logout. > With the patch, the desktop stays until logout is really confirmed, and is > still usable if the user clicks "Cancel". > > > Thanks, > > Wolfgang Bauer > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
