> On Feb. 29, 2016, 1:18 p.m., Kai Uwe Broulik wrote: > > src/scriptengines/qml/plasmoid/appletinterface.cpp, line 644 > > <https://git.reviewboard.kde.org/r/127218/diff/2/?file=446013#file446013line644> > > > > I think this is not optimal overall: > > > > Imagine you set both properties from QML: > > > > setConfigurationRequired(configuring, {}); > > emits conf required changed in applet > > emits both changed > > > > setConfigurationRequired(same, reason); > > emits conf required changed in applet > > emits both changed again > > > > but whatever.. :)
yeah, but that's the way requiring less api changes to Applet (that i don't want to get "too" qml friendly) - Marco ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127218/#review92902 ----------------------------------------------------------- On Feb. 29, 2016, 12:39 p.m., Marco Martin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127218/ > ----------------------------------------------------------- > > (Updated Feb. 29, 2016, 12:39 p.m.) > > > Review request for Plasma. > > > Repository: plasma-framework > > > Description > ------- > > unbreak api of Applet::SetConfigurationRequired + add bindings to > appletInterface as properties. > > > It would still need somewhere the creation of graphics for that, probably in > the containments code. > > > Diffs > ----- > > src/plasma/applet.h df57e94 > src/plasma/applet.cpp 4ce2d28 > src/plasma/private/applet_p.h e1aaef6 > src/plasma/private/applet_p.cpp 949c92e > src/scriptengines/qml/plasmoid/appletinterface.h 8dcac08 > src/scriptengines/qml/plasmoid/appletinterface.cpp 550438d > > Diff: https://git.reviewboard.kde.org/r/127218/diff/ > > > Testing > ------- > > > Thanks, > > Marco Martin > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
