----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127086/#review92924 -----------------------------------------------------------
Isn't raising the version a bit of a overkill for a module that only indicates RUNTIME requirement? Another way is to check for ISOcodes only with cmake 3.4. - Hrvoje Senjan On Feb. 16, 2016, 12:13 p.m., Elias Probst wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127086/ > ----------------------------------------------------------- > > (Updated Feb. 16, 2016, 12:13 p.m.) > > > Review request for Plasma. > > > Repository: plasma-workspace > > > Description > ------- > > Since fea67bd2 plasma-workspace requires CMake >= 3.4.0 as > pkg_get_variable used in cmake/FindIsoCodes.cmake isn't available in previous > releases. > > > Diffs > ----- > > CMakeLists.txt c2debaa3aeb24b4da9918642b8931002c205d228 > > Diff: https://git.reviewboard.kde.org/r/127086/diff/ > > > Testing > ------- > > Updated from CMake 3.3.1 to 3.4.3 and cmake/FindIsoCodes.cmake succeeded. > > > Thanks, > > Elias Probst > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
