> On March 4, 2016, 4:29 p.m., Marco Martin wrote: > > yep, the patch is correct... > > +1 for adding a test tough > > David Rosca wrote: > I'm for adding test too, but there are currently no tests in > plasma-workspace and also I think it won't be easy to test it. So maybe a > good thing to look into during sprint next week.
Eh, this is not plasma-workspace :D - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127277/#review93168 ----------------------------------------------------------- On March 4, 2016, 3:26 p.m., David Rosca wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127277/ > ----------------------------------------------------------- > > (Updated March 4, 2016, 3:26 p.m.) > > > Review request for Plasma. > > > Repository: plasma-framework > > > Description > ------- > > right() = x() + width() - 1 > bottom() = y() + height() - 1 > > > Diffs > ----- > > src/scriptengines/qml/plasmoid/containmentinterface.cpp 845bb4d > > Diff: https://git.reviewboard.kde.org/r/127277/diff/ > > > Testing > ------- > > > Thanks, > > David Rosca > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
