> On March 11, 2016, 11:23 p.m., Sebastian Kügler wrote: > > shell/main.cpp, line 135 > > <https://git.reviewboard.kde.org/r/127346/diff/1/?file=449175#file449175line135> > > > > We'll have multiple TestCorona's around if the Shell changes more than > > once. Not a big deal, since it's only in test mode, just some thing that > > struck me.
The idea is that we have `TestCorona` that observes how the ShellCorona gets set up and manages the test instances for the `plasmashell`. > On March 11, 2016, 11:23 p.m., Sebastian Kügler wrote: > > shell/tests/CMakeLists.txt, line 13 > > <https://git.reviewboard.kde.org/r/127346/diff/1/?file=449180#file449180line13> > > > > I wonder if we should use QTemporaryDir here, but that would mean that > > we have to set the environment var from the binary. Something to consider, > > but not critical. We are using QStandardPaths now, so probably can be changed. - Aleix ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127346/#review93425 ----------------------------------------------------------- On March 11, 2016, 9:26 p.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127346/ > ----------------------------------------------------------- > > (Updated March 11, 2016, 9:26 p.m.) > > > Review request for Plasma. > > > Repository: plasma-workspace > > > Description > ------- > > Makes it possible to test how/if a plasmoid behaves correctly on the most > similar environment possible to what the user would find on a production > system. > > * Loads a plasmoid on a panel and the desktop. > * Lets it test his own stuff > * Notifies, when done, if failed. > > There's still more to look into: > * what objects need to be passed, besides the `Plasma::AppletQuickItem`. > * good things to test > * how to test other shells than the desktop shell > > Nevertheless, it looks to me that it's a step forward. Comments welcome. > > > Diffs > ----- > > applets/analog-clock/contents/tests/testmain.qml PRE-CREATION > shell/CMakeLists.txt e553133 > shell/main.cpp d6e3640 > shell/shellmanager.h 17acbc6 > shell/shellmanager.cpp 3c3638f > shell/testcorona.h PRE-CREATION > shell/testcorona.cpp PRE-CREATION > shell/tests/CMakeLists.txt PRE-CREATION > shell/tests/plasma/shells/org.kde.plasmashelltest/contents/layout.js.in > PRE-CREATION > shell/tests/plasma/shells/org.kde.plasmashelltest/contents/loader.qml > PRE-CREATION > shell/tests/plasma/shells/org.kde.plasmashelltest/metadata.desktop > PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/127346/diff/ > > > Testing > ------- > > > Thanks, > > Aleix Pol Gonzalez > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
