----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127455/#review93841 -----------------------------------------------------------
src/declarativeimports/calendar/qml/MonthView.qml (lines 36 - 37) <https://git.reviewboard.kde.org/r/127455/#comment63938> While I agree, this property is stupid, it would break our API-compatibility promise. - Kai Uwe Broulik On März 21, 2016, 9:11 nachm., Martin Klapetek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127455/ > ----------------------------------------------------------- > > (Updated März 21, 2016, 9:11 nachm.) > > > Review request for Plasma. > > > Bugs: 360683 > http://bugs.kde.org/show_bug.cgi?id=360683 > > > Repository: plasma-framework > > > Description > ------- > > This removes some old cruft that is not really used and serves > basically only as a bool property for checking if it's null and > wheter it equals the last activated date. > > This can be done without it by simply resetting the current selected > date (another property) to "today". > > I decided to leave the useless property in for the time being > to allow for some buffer time between the -workspace and -framework > release so that it does not throw errors (ie. if distros will > ship 5.6 + p-f 5.21). > > > Diffs > ----- > > src/declarativeimports/calendar/qml/DayDelegate.qml 6877150 > src/declarativeimports/calendar/qml/DaysCalendar.qml 8248a8f > src/declarativeimports/calendar/qml/MonthView.qml 76c605a > > Diff: https://git.reviewboard.kde.org/r/127455/diff/ > > > Testing > ------- > > Selection is properly cleared. > > > Thanks, > > Martin Klapetek > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel