----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127467/#review93978 -----------------------------------------------------------
src/client.cpp (lines 62 - 65) <https://git.reviewboard.kde.org/r/127467/#comment64005> Isn't KService::serviceByStorageId sufficient? The docs say "This function will try very hard to find a matching service." and it's what eg. Battery Monitor uses to determin the icon for the app that holds a PM inhibition and it works surprisingly well. - Kai Uwe Broulik On März 25, 2016, 1:39 nachm., David Rosca wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127467/ > ----------------------------------------------------------- > > (Updated März 25, 2016, 1:39 nachm.) > > > Review request for Plasma. > > > Repository: plasma-pa > > > Description > ------- > > Implement heuristics searching for icon in desktop files. > Also try stream name to find icon if everything else fails. > > > Diffs > ----- > > CMakeLists.txt 3a0f690 > src/CMakeLists.txt b3e1855 > src/client.h 3b9050e > src/client.cpp 6fc5814 > src/qml/ClientIcon.qml 83545a1 > > Diff: https://git.reviewboard.kde.org/r/127467/diff/ > > > Testing > ------- > > Streams now have icons even when icon_name or binary properites are empty. > > > Thanks, > > David Rosca > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel