> On March 31, 2016, 1:47 p.m., Sebastian Kügler wrote: > > src/card.cpp, line 47 > > <https://git.reviewboard.kde.org/r/127498/diff/3/?file=454300#file454300line47> > > > > Perhaps we can just drop this conditional and make it require PA >= 5.0? > > > > The reason is to reduce silent failures, #ifdefs sounds like a neat > > thing, but it quickly gets out of hand when people expect software to have > > the same features, and then it doesn't, but they don't see build failures. > > > > My (current) Kubuntu has 6.0, my Debian Unstable has 8.0, I haven't > > investigated others, but it doesn't seem outrageous to require PA 5.0 for > > Plasma 5.7?
Makes sense, even Debian Stable has 5.0. Also we can now drop custom FindPulseAudio.cmake as 5.0 includes PulseAudioConfig.cmake. - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127498/#review94153 ----------------------------------------------------------- On March 26, 2016, 9:07 a.m., David Rosca wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127498/ > ----------------------------------------------------------- > > (Updated March 26, 2016, 9:07 a.m.) > > > Review request for Plasma. > > > Repository: plasma-pa > > > Description > ------- > > Change some warnings to todo/fixme and fix the others. > > > Diffs > ----- > > src/card.cpp 2e251a7 > src/context.cpp 115c8a7 > src/pulseaudio.cpp 1488784 > > Diff: https://git.reviewboard.kde.org/r/127498/diff/ > > > Testing > ------- > > > Thanks, > > David Rosca > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
